[ovs-dev] [PATCH] ovn-northd: Warn when the peer of a router port is a switch port.

Ryan Moats rmoats at us.ibm.com
Mon Jul 18 18:55:24 UTC 2016


Guru Shetty <guru at ovn.org> wrote on 07/18/2016 01:48:36 PM:

> From: Guru Shetty <guru at ovn.org>
> To: Ryan Moats/Omaha/IBM at IBMUS
> Cc: ovs dev <dev at openvswitch.org>
> Date: 07/18/2016 01:48 PM
> Subject: Re: [ovs-dev] [PATCH] ovn-northd: Warn when the peer of a
> router port is a switch port.
>
> On 18 July 2016 at 11:44, Ryan Moats <rmoats at us.ibm.com> wrote:
> "dev" <dev-bounces at openvswitch.org> wrote on 07/18/2016 03:39:56 AM:
>
> > From: Gurucharan Shetty <guru at ovn.org>
> > To: dev at openvswitch.org
> > Date: 07/18/2016 01:39 PM
> > Subject: [ovs-dev] [PATCH] ovn-northd: Warn when the peer of a
> > router port is a switch port.
> > Sent by: "dev" <dev-bounces at openvswitch.org>
> >
> > Signed-off-by: Gurucharan Shetty <guru at ovn.org>
> > ---
>
> Is just printing a warning enough?
>
> I mean, shouldn't we try to *stop* this from happening?
> Stop a admin from creating a wrong config? I guess, that is what the
> warning does. There is also a "continue", which does "stop" the
> config from going through to SB database.
>

And... that's what I get for looking at the patch by itself and not at
the full patched code...

Since it does skip the config from triggering the issue,

Acked-by: Ryan Moats <rmoats at us.ibm.com>



More information about the dev mailing list