[ovs-dev] [PATCH] ovn-northd: Warn when the peer of a router port is a switch port.

[Ben Pfaff]

On Mon, Jul 18, 2016 at 01:39:56AM -0700, Gurucharan Shetty wrote:
> Signed-off-by: Gurucharan Shetty <guru at ovn.org>

Hmm.  I think that the existing code here is a little strange and can be
fixed up in a better way.

Let me post a second version of my series from a few minutes ago.

> ---
>  ovn/northd/ovn-northd.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c
> index 7ce509d..0a093c7 100644
> --- a/ovn/northd/ovn-northd.c
> +++ b/ovn/northd/ovn-northd.c
> @@ -2603,6 +2603,14 @@ build_lrouter_flows(struct hmap *datapaths, struct hmap *ports,
>                      continue;
>                  }
>  
> +                if (peer->nbs) {
> +                    static struct vlog_rate_limit rl =
> +                            VLOG_RATE_LIMIT_INIT(5, 1);
> +                    VLOG_WARN_RL(&rl, "Bad configuration: The peer of router "
> +                                 "port %s is a switch port", op->key);
> +                    continue;
> +                }
> +
>                  ds_clear(&match);
>                  ds_put_format(&match, "outport == %s && reg0 == ",
>                                peer->json_key);
> -- 
> 1.9.1
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev