[ovs-dev] [PATCH] stream-unix: only use path-based socket names

Ben Pfaff blp at ovn.org
Wed Jul 20 03:08:21 UTC 2016


On Tue, Jul 19, 2016 at 05:05:51PM -0300, Thadeu Lima de Souza Cascardo wrote:
> FreeBSD returns a socklen of sockaddr_storage when doing an accept on an unix
> STREAM socket. The current code will assume it means a sun_path larger than 0.
> 
> That breaks some tests like the one below which don't expect to find "unix::" on
> the logs.
> 
> As a Linux abstract address would not have a more useful name either, it's
> better to check that sun_path starts with a non-zero byte and return 0 length in
> case it doesn't.
> 
> 402: ovs-ofctl replace-flows with --bundle      FAILED (ovs-ofctl.at:2928)
> 2016-07-08T12:44:30.068Z|00020|vconn|DBG|unix:: sent (Success): OFPT_HELLO (OF1.6) (xid=0x1):
> 
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo at redhat.com>

Applied, thanks!

If this should be backported to an earlier release branch, let me know
and I'll take care of it.



More information about the dev mailing list