[ovs-dev] [PATCH v3] [OVN-northd] Rename nbs/nbr port names tonbsp/nbrp

Justin Pettit jpettit at ovn.org
Wed Jul 20 23:11:50 UTC 2016


> On Jul 20, 2016, at 7:25 AM, Hui Kang <kangh at us.ibm.com> wrote:
> 
> "dev" <dev-bounces at openvswitch.org> wrote on 07/19/2016 04:15:56 PM:
> 
> > From: Justin Pettit <jpettit at ovn.org>
> > To: Hui Kang <hkang.sunysb at gmail.com>
> > Cc: dev at openvswitch.org
> > Date: 07/19/2016 04:16 PM
> > Subject: Re: [ovs-dev] [PATCH v3] [OVN-northd] Rename nbs/nbr port 
> > names to nbsp/nbrp
> > Sent by: "dev" <dev-bounces at openvswitch.org>
> > 
> > 
> > > On Jul 19, 2016, at 11:36 AM, Hui Kang <hkang.sunysb at gmail.com> wrote:
> > > 
> > > These variables indicate ports in nb switches or routers.
> > > 
> > > Signed-off-by: Hui Kang <kangh at us.ibm.com>
> > > 
> > > --
> > > v2->v3:
> > > - rebase agains master branch
> > > v1->v2:
> > > - modify commit message
> > > ---
> > 
> > Thanks for the patch.  Just a few things first, though:
> > 
> >    - A couple of lines you changed went over 80 columns.  I'll wrap those.
> >    - The way you wrote your revision history, it shows up in the 
> > commit message.  I'll fix it up.
> >    - Your author email address and Signed-off-by don't match.  Which
> > do you want to use?
> 
> I'd like to use the corporate email account, which is kangh at us.ibm.com
> I will figure out how to setup the mail account in my dev box and keep them
> consistent next time. Thanks for your help.

Great.  I've updated the author, and I'll push it in a minute.

--Justin





More information about the dev mailing list