[ovs-dev] [PATCH] ovn: will not create patch port whose peer named "<error>".

[nickcooper-zhangtonghao]

Hi,
When linking the logical switch to the logical router, I find some WARN info in the ovs-vswitch log file.
I think it is not necessary to create the logical patch port whose peer named “<error>”.

commands:
	ovn-nbctl lr-add lr0
	ovn-nbctl lrp-add lr0 lr0-p0 00:11:22:33:44:55 192.168.100.10/24
	ovn-nbctl ls-add ls0
	ovn-nbctl lsp-add ls0 ls0-p0
	ovn-nbctl set Logical_switch_port ls0-p0 type=router options:router-port=lr0-p0

ovs-vswitch.log
	23 2016-07-20T09:00:00.309Z|00022|bridge|INFO|bridge br-int: added interface patch-lr0-p0-to-<error> on port 1
	24 2016-07-20T09:00:00.513Z|00023|bridge|INFO|bridge br-int: added interface patch-ls0-p0-to-lr0-p0 on port 2
	25 2016-07-20T09:00:00.513Z|00024|bridge|INFO|bridge br-int: added interface patch-lr0-p0-to-ls0-p0 on port 3
	26 2016-07-20T09:00:00.514Z|00025|dpif|WARN|system at ovs-system: failed to query port patch-lr0-p0-to-<error>: Invalid argument


ovn: will not create patch port whose peer named “<error>”.

It is not necessary to create the logical patch port whose peer named "<error>".

Signed-off-by: nickcooper-zhangtonghao <nickcooper-zhangtonghao at opencloud.tech>
---
 ovn/controller/patch.c | 4 ++++
 tutorial/ovs-sandbox   | 4 +++-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/ovn/controller/patch.c b/ovn/controller/patch.c
index 52d9e8d..ce22317 100644
--- a/ovn/controller/patch.c
+++ b/ovn/controller/patch.c
@@ -353,6 +353,10 @@ add_logical_patch_ports(struct controller_ctx *ctx,
                 continue;
             }
 
+            if (!strcmp(peer, "<error>")) {
+                continue;
+            }
+
             char *src_name = patch_port_name(local, peer);
             char *dst_name = patch_port_name(peer, local);
             create_patch_port(ctx, "ovn-logical-patch-port", local,
-- 
1.8.3.1