[ovs-dev] [PATCH] debian: Fix upgrade from OVS-2.5 to newer OVS.

[Joe Stringer]

On 19 July 2016 at 11:15, Joe Stringer <joe at ovn.org> wrote:
> On 24 June 2016 at 19:06, Ben Pfaff <blp at ovn.org> wrote:
>> On Wed, Jun 22, 2016 at 11:30:16AM -0700, Guru Shetty wrote:
>>> On 17 June 2016 at 12:42, Joe Stringer <joe at ovn.org> wrote:
>>>
>>> > Commit 0dcc739e7a28 ("debian: Move ovs-lib to openvswitch-common.")
>>> > shifted a file between debian packages, but didn't update the
>>> > destination package annotations to indicate that it replaces a file
>>> > from earlier versions of the source package.
>>> >
>>> > As a result, if one installs openvswitch-switch-2.5* and then tries to
>>> > upgrade to openvswitch-{switch,common}-2.5.90+, the install of
>>> > openvswitch-common will fail like the following:
>>> >
>>> > dpkg: error processing archive
>>> > /tmp/openvswitch-common_2.5.90-1_amd64.deb (--install):
>>> > trying to overwrite '/usr/share/openvswitch/scripts/ovs-lib', which is
>>> > also in package openvswitch-switch 2.5.0-1
>>> >
>>> > Fix the issue by adding "Replaces" and "Breaks" tags to the new
>>> > openvswitch-common section of debian/control.
>>> >
>>> > Fixes: 0dcc739e7a28 ("debian: Move ovs-lib to openvswitch-common.")
>>> > Signed-off-by: Joe Stringer <joe at ovn.org>
>>> >
>>>
>>> One option is to move back ovs-lib to openvswitch-switch and make
>>> ovn-common depend on openvswitch-switch too. ovn-common is used by
>>> ovn-central and ovn-host and both of them have a dependency on
>>> openvswitch-switch anyway, so it is probably not a bad thing.
>>>
>>> Ben do you have any opinions on what is the "debain way" here?
>>
>> I don't think there's anything wrong with that proposal but one wouldn't
>> normally make packaging choices on the basis that someone might type
>> dpkg commands in the wrong order.
>
> OK, it seems like the approach in this patch is fine so I will apply it soon.

Applied.