[ovs-dev] [PATCH 1/2] tests: Ignore proxy configuration in kernel testsuite.

[Jarno Rajahalme]

> On Jul 14, 2016, at 17:32, Ben Pfaff <blp at ovn.org> wrote:
> 
>> On Thu, Jul 14, 2016 at 03:07:21AM -0700, Jarno Rajahalme wrote:
>> 
>>> On Jul 13, 2016, at 9:36 PM, Ben Pfaff <blp at ovn.org> wrote:
>>> 
>>> On Wed, Jul 06, 2016 at 06:02:45AM -0700, Jarno Rajahalme wrote:
>>>> 
>>>>> On Jul 1, 2016, at 8:30 PM, Ben Pfaff <blp at ovn.org> wrote:
>>>>> 
>>>>> On Tue, Jun 21, 2016 at 09:57:15AM -0700, Jarno Rajahalme wrote:
>>>>>> Add '--noproxy' parameter to 'wget' so that the test cases do not try
>>>>>> to use a proxy that may be configured in the test environment.
>>>>>> 
>>>>>> Signed-off-by: Jarno Rajahalme <jarno at ovn.org>
>>>>> 
>>>>> We could do something like this to turn it off without messing with
>>>>> every call to wget.  Lots of programs use these variables so it's
>>>>> possible that it would fix other tests later too.
>>>>> 
>>>>> diff --git a/tests/atlocal.in b/tests/atlocal.in
>>>>> index f174061..c49e9b0 100644
>>>>> --- a/tests/atlocal.in
>>>>> +++ b/tests/atlocal.in
>>>>> @@ -129,3 +129,13 @@ if nc --version 2>&1 | grep -q nmap.org; then
>>>>> else
>>>>>   NC_EOF_OPT="-q 1"
>>>>> fi
>>>>> +
>>>>> +# Turn off proxies.
>>>>> +AS_UNSET([http_proxy])
>>>>> +AS_UNSET([https_proxy])
>>>>> +AS_UNSET([ftp_proxy])
>>>>> +AS_UNSET([no_proxy])
>>>>> +AS_UNSET([HTTP_PROXY])
>>>>> +AS_UNSET([HTTPS_PROXY])
>>>>> +AS_UNSET([FTP_PROXY])
>>>>> +AS_UNSET([NO_PROXY])
>>>> 
>>>> This would be better, but I can't get it to work:
>>>> 
>>>> ./atlocal: line 134: syntax error near unexpected token `[http_proxy]'
>>>> ./atlocal: line 134: `AS_UNSET([http_proxy])'
>>>> system-kmod-testsuite: error: invalid content: atlocal
>>>> Makefile:5985: recipe for target 'check-kernel' failed
>>>> make: *** [check-kernel] Error 1
>>> 
>>> It looks like AS_UNSET was new in Autoconf 2.65.  Maybe you are using an
>>> older version.
>> 
>> autoconf --version says 2.69.
> 
> Huh.  I don't know, then.
> 
>>> Perhaps just "unset" is adequate with the shells that our users use in
>>> practice.  Try this?
>> 

Bare unset works, I'll send a v2.

  Jarno