[ovs-dev] [PATACH]netdev-dpdk: remove duplicated code in netdev_dpdk_get_status

[Daniele Di Proietto]

Thanks for the patch!

I had to manually unwrap some long lines.  Could you maybe use git
send-email next time?

Anyway, I added you to AUTHORS and applied this to master

Thanks,

Daniele

2016-07-25 1:37 GMT-07:00 <xu.binbin1 at zte.com.cn>:

> From caeb84217c38ccd0b2076689fd36b578c00678ad Mon Sep 17 00:00:00 2001
> From: xubinbin <xu.binbin1 at zte.com.cn>
> Date: Thu, 21 Jul 2016 21:52:29 +0800
> Subject: [PATCH] netdev-dpdk: remove duplicated code in
> netdev_dpdk_get_status
>
> Put "driver_name" into "args" twice, that's meaninglessness.
> So need to remove duplicated code.
>
> Signed-off-by: Binbin Xu <xu.binbin1 at zte.com.cn>
> ---
>  lib/netdev-dpdk.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
> index 85b18fd..b515bee 100644
> --- a/lib/netdev-dpdk.c
> +++ b/lib/netdev-dpdk.c
> @@ -2091,8 +2091,6 @@ netdev_dpdk_get_status(const struct netdev *netdev,
> struct smap *args)
>      rte_eth_dev_info_get(dev->port_id, &dev_info);
>      ovs_mutex_unlock(&dev->mutex);
>
> -    smap_add_format(args, "driver_name", "%s", dev_info.driver_name);
> -
>      smap_add_format(args, "port_no", "%d", dev->port_id);
>      smap_add_format(args, "numa_id", "%d",
> rte_eth_dev_socket_id(dev->port_id));
>      smap_add_format(args, "driver_name", "%s", dev_info.driver_name);
> --
> 1.8.3.1
> --------------------------------------------------------
> ZTE Information Security Notice: The information contained in this mail
> (and any attachment transmitted herewith) is privileged and confidential
> and is intended for the exclusive use of the addressee(s).  If you are not
> an intended recipient, any disclosure, reproduction, distribution or other
> dissemination or use of the information contained is strictly prohibited.
> If you have received this mail in error, please delete it and notify us
> immediately.
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>