[ovs-dev] [PATCH v2] ovn: the implementation of icmp4 reject actions.

Ben Pfaff blp at ovn.org
Wed Jul 27 19:56:43 UTC 2016


On Wed, Jul 20, 2016 at 01:19:37AM -0700, nickcooper-zhangtonghao wrote:
> Hi Ryan,
> Thank you for your advice. The controller will drop the icmp4 packet whose eth.src or eth.dst is
> broadcast/multicast address and the type of icmp4 is “destination unreachable”. That may reduce 
> the broadcast storm attack(e.g. icmp flood, dhcp flood). I write the rate limiting of icmp4 into 
> my to-do list. Thanks.

Please don't put additional commentary above a commit message.  "git am"
can't distinguish it from the commit message itself.

This patch needs a rebase due to conflicts.

Please don't use bare sprintf() in OVS.  Use snprintf() or xasprintf()
or ds_put_format() instead.



More information about the dev mailing list