[ovs-dev] [PATCH] ovsdb: Fix memory leak in execute_update.

Andy Zhou azhou at ovn.org
Wed Jul 27 20:26:13 UTC 2016


On Tue, Jul 26, 2016 at 6:28 PM, William Tu <u9012063 at gmail.com> wrote:

> Valgrind testcase 1804 ovsdb-server.at:1023 insert rows, update rows by
> value
> reports the following leak.
>     json_from_string (json.c:1025)
>     execute_update (replication.c:614), similarily at execute_delete()
>     process_table_update (replication.c:502)
>     process_notification.part.5 (replication.c:445)
>     process_notification (replication.c:402)
>     check_for_notifications (replication.c:418)
>     replication_run (replication.c:110)
>
> Signed-off-by: William Tu <u9012063 at gmail.com>
>

Tested, it removed the memory leak reported.
I think declare 'where' as 'struct json' instead of 'const struct json'
will make the code easier to read.

 Acked-by: Andy Zhou <azhou at ovn.org>


>



More information about the dev mailing list