[ovs-dev] [PATCH 2/2] route-table: flush addresses list when route table is reset

Thadeu Lima de Souza Cascardo cascardo at redhat.com
Wed Jul 27 22:20:33 UTC 2016


On Wed, Jul 27, 2016 at 01:48:47PM -0700, Ben Pfaff wrote:
> On Sun, Jul 24, 2016 at 01:07:27PM -0300, Thadeu Lima de Souza Cascardo wrote:
> > When the route table is reset, the addresses list may be out of date, as we race
> > for the many netlink socket notifications.
> > 
> > A quick fix for this is flushing the addresses list, before dumping the routes
> > and gathering source addresses for them.
> > 
> > That way, instead of using invalid source addresses or preventing an entry to be
> > added because of missing source addresses, repeated tests showed the correct
> > entry is always added.
> > 
> > Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo at redhat.com>
> 
> This gives me a compiler error:
>     ../lib/route-table.c:154:5: error: implicit declaration of function 'netdev_get_addrs_list_flush' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
> 
> I also noticed that netdev_get_addrs_list_flush() is not available on
> Windows.
> 
> Thanks,
> 
> Ben.

Hum... I'll take a look at that and resubmit.

Thanks.
Cascardo.



More information about the dev mailing list