[ovs-dev] [PATCH ovn-controller] Physical: persist tunnels

Ryan Moats rmoats at us.ibm.com
Wed Jul 27 23:48:37 UTC 2016



Ben Pfaff <blp at ovn.org> wrote on 07/27/2016 04:14:07 PM:

> From: Ben Pfaff <blp at ovn.org>
> To: Ryan Moats/Omaha/IBM at IBMUS
> Cc: dev at openvswitch.org
> Date: 07/27/2016 04:14 PM
> Subject: Re: [ovs-dev] [PATCH ovn-controller] Physical: persist tunnels
>
> On Mon, Jul 25, 2016 at 04:28:52PM +0000, Ryan Moats wrote:
> > While commit ab39371d68842b7e4000cc5d8718e6fc04e92795
> > (ovn-controller: Handle physical changes correctly) addressed
> > unit test failures, it did so at the cost of performance: [1]
> > notes that ovn-controller cpu usage is now pegged at 100%.
> >
> > Root cause of this is that while the storage for tunnels is
> > persisted, their creation is not (which the above changed
> > incorrectly assumed was the case).  This patch persists
> > tunneled data across invocations of physical_run.  A side
> > effect is that renaming of localfvif_map_changed variable
> > to physical_map_changed and extending its scope to include
> > tunnel changes.
> >
> > [1] http://openvswitch.org/pipermail/dev/2016-July/076058.html
> >
> > Signed-off-by: Ryan Moats <rmoats at us.ibm.com>
>
> Thanks for the fix.
>
> I applied this to master, folding in the following incremental which is
> mostly style but I think that the extra check on tun->type is a bug fix
> albeit for a corner case.  Please take a look.
>
> --8<--------------------------cut here-------------------------->8--

I think that's fine

and if it isn't we'll figure it out...

Ryan



More information about the dev mailing list