[ovs-dev] [PATCH v2] netdev-dpdk: Add Flow Control support.

[Bodireddy, Bhanuprakash]

>-----Original Message-----
>From: Chandran, Sugesh
>Sent: Thursday, July 28, 2016 4:30 PM
>To: diproiettod at ovn.org; Bodireddy, Bhanuprakash
><bhanuprakash.bodireddy at intel.com>; dev at openvswitch.org
>Cc: Chandran, Sugesh <sugesh.chandran at intel.com>
>Subject: [PATCH v2] netdev-dpdk: Add Flow Control support.
>
>Add support for flow-control(mac control frame) to DPDK enabled physical
>port types. By default, the flow-control is OFF on both rx and tx side.
>The flow control can be enabled/disabled either when adding a port to OVS or
>at run time.
>
>For eg:
>To enable flow control support at tx side while adding a port, add the 'tx-flow-
>ctrl' option to the 'ovs-vsctl add-port' command-line as below.
>
> 'ovs-vsctl add-port br0 dpdk0 -- \
>  set Interface dpdk0 type=dpdk options:tx-flow-ctrl=true'
>
>Similarly to enable rx flow control,
> 'ovs-vsctl add-port br0 dpdk0 -- \
>  set Interface dpdk0 type=dpdk options:rx-flow-ctrl=true'
>
>And to enable the flow control auto-negotiation,  'ovs-vsctl add-port br0
>dpdk0 -- \
>  set Interface dpdk0 type=dpdk options:flow-ctrl-autoneg=true'
>
>To turn ON the tx flow control at run time(After the port is being added to
>OVS), the command-line input will be,  'ovs-vsctl set Interface dpdk0
>options:tx-flow-ctrl=true'
>
>The flow control parameters can be turned off by setting 'false' to the
>respective parameter. To dsiable the flow control at tx side,  'ovs-vsctl set
>Interface dpdk0 options:tx-flow-ctrl=false'
>
>Signed-off-by: Sugesh Chandran <sugesh.chandran at intel.com>

LGTM, I tested it and can apply the rx flow control setting even when the interface is transmitting.
Acked-by: Bhanuprakash Bodireddy <Bhanuprakash.bodireddy at intel.com>

Regards,
Bhanu Prakash.