[ovs-dev] [PATCH v2 18/26] ofp-util: Do not free() field that is not allocated.

Jarno Rajahalme jarno at ovn.org
Fri Jul 29 00:56:10 UTC 2016


Group properties field array is not dynamically allocated, so it
should not be freed.  This has not been a problem, as this function
has not been called by anyone so far, but following patch will.

Signed-off-by: Jarno Rajahalme <jarno at ovn.org>
---
 lib/ofp-util.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index 06b48b8..175ae2d 100644
--- a/lib/ofp-util.c
+++ b/lib/ofp-util.c
@@ -8205,7 +8205,6 @@ void
 ofputil_uninit_group_desc(struct ofputil_group_desc *gd)
 {
     ofputil_bucket_list_destroy(&gd->buckets);
-    free(&gd->props.fields);
 }
 
 /* Decodes the OpenFlow group description request in 'oh', returning the group
-- 
2.1.4




More information about the dev mailing list