[ovs-dev] [PATCH 0/5] check-kernel: add 802.1ad tests

[Joe Stringer]

On 29 July 2016 at 13:11, Eric Garver <e at erig.me> wrote:
> Hi Joe,
>
> Thanks for providing feedback.
>
> On Fri, Jul 29, 2016 at 11:14:36AM -0700, Joe Stringer wrote:
>> On 28 July 2016 at 10:54, Eric Garver <e at erig.me> wrote:
>> > This series adds 6 test cases to the "check-kernel" make target for
>> > 802.1ad. It is meant as a counterpart to the 802.1ad work currently
>> > going on and being discussed on the dev list.
>> >
>> > User space support for 802.1ad is being worked on by Xiao Liang (based
>> > on Thomas F Herbert's work).
>> >
>> > Kernel support is being worked on by myself (also based on Tom's work).
>> > I will post (and CC ovs-dev) the kernel series once net-next opens again
>> > for new content. If there is interest I can post that series to ovs-dev
>> > for discussion in the mean time.
>> >
>> > These patches have been tested with Xiao's most recent series and my yet
>> > to be posted kernel series.
>>
>> Thanks for working on system tests, it's good to see that they're
>> useful for development.
>>
>> I see that there are three categories of tests here:
>> * Basic sanity tests with double-tagging
>> * Conntrack interaction tests with double-tagging
>> * 802.1ad push/pop and tunnelling in OVS
>>
>> Would the first two categories be suitable for inclusion before the
>> OVS 802.1ad support is added to OVS, since they're just using upstream
>> linux 802.1ad support?
>
> The first category ("datapath" or as you called it, Basic sanity tests
> with double-tagging) can be included before 802.1ad support is added.
> This verifies basic kernel support of 802.1ad.

OK, great. I could apply these first two patches of the series if
we're happy that supported kernels 3.10+ either consistently skip or
pass them.

> I don't think the CVLAN conntrack tests will work without 802.1ad
> support. The flow keys specifies icmp. Without 802.1ad in the kernel the
> inner VLAN TPID, 0x8100, will be parsed as eth.type. So the key won't
> match ICMP. Note, there is already an equivalent 802.1q VLAN test.

That makes sense, I couldn't get these particular tests to pass on any
of 3.13,3.19,4.2, without applying the 802.1ad patches.

>> I think that the existing VLAN tests are primarily checking that OVS
>> works in conjunction with VLANs configured using netdevices. Likewise
>> with the first two categories of tests here. Maybe we should consider
>> also extending the tests to configure VLANs via OVS (to use OVS
>> push/pop infrastructure) and ensure those codepaths work too. I think
>
> Probably a good idea.
>
>> that's what the third category of tests are trying to do, but there
>> didn't seem to be a basic 802.1q test (which I would also expect to
>> work today).
>
> Agreed.
>
>> Which kernel versions should be sufficient to run these tests? I tried
>> running on an Ubuntu 14.04 install with kernel 3.13.0-91 with master
>> OVS (+this series) and even the basic sanity 802.1ad tests failed,
>> with 100% packet loss. My 'ip' command seems to understand 802.1ad,
>> although I can't recall if I am running a custom version of iproute.
>
> Tests passing with:
>         - 4.7.0-rc7 (with my 802.1ad patches)
>
> Tests skipped (no failures):
>         - 4.7.0-rc4
>         - RHEL 7.2-ish (3.10 with backports)
>
> 802.1ad was added in kernel 3.10. I will try an upstream 3.10-era kernel.

Thanks.