[ovs-dev] [PATCH v2 17/26] ofproto-dpif-xlate: Hash only fields specified for 'hash' selection method.

Ben Pfaff blp at ovn.org
Fri Jul 29 22:57:12 UTC 2016


On Thu, Jul 28, 2016 at 05:56:09PM -0700, Jarno Rajahalme wrote:
> The mask for non-present fields in struct field_array is always zero,
> so hashing a prerequisite field that was not also specified for the
> "hash" selection method boiled down to hashing a all-zeroes value and
> unwildcarding the prerequisite field.  Now that mf_are_prereqs_ok()
> already takes care of unwildcarding, we can simplify the code by
> hashing only the specified fields.
> 
> Also change the test case to include fields that have prerequisities.
> 
> Signed-off-by: Jarno Rajahalme <jarno at ovn.org>

Much nicer, thanks.

Acked-by: Ben Pfaff <blp at ovn.org>



More information about the dev mailing list