[ovs-dev] [PATCH v2 18/26] ofp-util: Do not free() field that is not allocated.

[Jarno Rajahalme]

> On Jul 29, 2016, at 3:57 PM, Ben Pfaff <blp at ovn.org> wrote:
> 
> On Thu, Jul 28, 2016 at 05:56:10PM -0700, Jarno Rajahalme wrote:
>> Group properties field array is not dynamically allocated, so it
>> should not be freed.  This has not been a problem, as this function
>> has not been called by anyone so far, but following patch will.
>> 
>> Signed-off-by: Jarno Rajahalme <jarno at ovn.org>
> 
> That must have been a surprise.

I was staring at that free() for a while wondering how on earth it could have worked. The argument is never NULL either. Then I though of checking if it is ever called!

> 
> Acked-by: Ben Pfaff <blp at ovn.org>

Thanks for the review,

  Jarno