[ovs-dev] [PATCH monitor_cond V6 00/11] Implement conditional monitoring

[Ben Pfaff]

On Tue, May 17, 2016 at 05:26:58PM +0300, Liran Schour wrote:
> This patch series implements conditional monitoring by introducing an OVSDB
> RFC extension with 2 new JSON-RPC methods: "monitor_cond" and
> "monitor_cond_update". Specification of this extension is defined in the
> ovsdb-server (1) man page.
> Monitor2 is now merged into monitor_cond. A monitor_cond session with an empty 
> condition, will behave exactly like monitor2 and will get update2 notifications
> on all rows.
> 
> This patch series is also available on: https://github.com/liranschour/ovs.git
> branch monitor_cond_ovn.

Hi Liran, thanks for the new version of the patch series, and sorry that
it's taken a while to review it.  I'm reviewing it today based on the
branch listed above, as fetched a few minutes ago.

I did a build on the series as a whole.  "sparse" issues some warnings.
Probably these variables should be declared "static":

    ../ovn/controller/binding.c:151:13: warning: symbol 'g_lports' was not declared. Should it be static?
    ../ovn/controller/binding.c:232:13: warning: symbol 'g_peer_lports' was not declared. Should it be static?

I ran the tests and they passed.

I'll review each of the patches now.