[ovs-dev] [PATCH v3 4/5] ovn-controller: Assign conntrack zones for gateway router.

Ben Pfaff blp at ovn.org
Thu Jun 2 21:19:46 UTC 2016


On Thu, May 19, 2016 at 01:02:33PM -0700, Gurucharan Shetty wrote:
> OVS NAT currently cannot do snat and dnat in the same zone.
> So we need two zones per gateway router.
> 
> Signed-off-by: Gurucharan Shetty <guru at ovn.org>

We're running out of registers quickly, but we're also using a full
32-bit register when we only need 16 bits, so there's considerable room
to economize later if necessary.

Please update ovn-architecture(7) to mention the new connection tracking
zones (the existing one is already mentioned).

There are a couple of instances of
+            char *dnat = xasprintf(UUID_FMT"_%s",
+                                   UUID_ARGS(&binding->datapath->header_.uuid),
+                                   "dnat");
+            char *snat = xasprintf(UUID_FMT"_%s",
+                                   UUID_ARGS(&binding->datapath->header_.uuid),
+                                   "snat");
or similar.  Do you think it would be worth having a helper function (or
two) so that they are harder to get out-of-sync?

Acked-by: Ben Pfaff <blp at ovn.org>



More information about the dev mailing list