[ovs-dev] [PATCH v2 1/2] tests: Wait for ARPs to be sent in tunnel-push-pop.

[Ben Pfaff]

On Fri, May 20, 2016 at 11:42:07AM -0700, Daniele Di Proietto wrote:
> Otherwise the tests can fail under heavy load (or with valgrind).
> 
> Signed-off-by: Daniele Di Proietto <diproiettod at vmware.com>
> ---
>  tests/tunnel-push-pop.at | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/tests/tunnel-push-pop.at b/tests/tunnel-push-pop.at
> index 64a0cbe..4695bb7 100644
> --- a/tests/tunnel-push-pop.at
> +++ b/tests/tunnel-push-pop.at
> @@ -43,6 +43,11 @@ dnl Check ARP request
>  AT_CHECK([ovs-vsctl -- set Interface p0 options:pcap=p0.pcap])
>  
>  AT_CHECK([ovs-appctl netdev-dummy/receive int-br 'in_port(2),eth(src=aa:55:aa:55:00:00,dst=f8:bc:12:ff:ff:ff),eth_type(0x0800),ipv4(src=1.1.3.92,dst=1.1.3.88,proto=1,tos=0,ttl=64,frag=no),icmp(type=0,code=0)'])
> +
> +dnl Wait for the two ARP requests to be sent. Sometimes the system
> +dnl can be slow (e.g. under valgrind)
> +OVS_WAIT_UNTIL(test `ovs-pcap p0.pcap | sort | uniq | wc -l` -ge 2)

Please use [] to quote the argument to OVS_WAIT_UNTIL.

Acked-by: Ben Pfaff <blp at ovn.org>