[ovs-dev] [PATCH] ofproto: Add relaxed group_mod command ADD_OR_MOD

Ben Pfaff blp at ovn.org
Thu Jun 2 23:03:02 UTC 2016


On Sat, May 21, 2016 at 12:42:49AM +0200, Jan Scheurich wrote:
> *** Reposting the patch once more. First two attempts got corrupted ***
> *** Sorry, still trying to find a suitable email client ***

Hi, thanks for the patch.  It seems almost ready to me.  I have a few
comments.

In some places, this is called "add_or_modify" and in other places just
"write".  I suggest using a consistent name.

Please add a test for the new command.

In the documentation, please note that this uses an Open vSwitch
extension to OpenFlow and that it only works with Open vSwitch 2.6 or
later.

Please add an item mentioning this new command to NEWS.

Thanks,

Ben.



More information about the dev mailing list