[ovs-dev] [PATCH V2 1/4] tests: Fixed access denied on ovs-vswitchd.log

Ben Pfaff blp at ovn.org
Thu Jun 2 23:20:48 UTC 2016


vlog/close isn't Windows-only, so I guess that something else must have
happened.

On Thu, Jun 02, 2016 at 11:10:03PM +0000, Paul Boca wrote:
> I did ran the test on Linux but failed saying vlog/close not recognized,
> maybe it was my mistake and didn't updated the sources.
> I will update and retest before submitting the next version.
> 
> Regards,
> Paull
> 
> > -----Original Message-----
> > From: Ben Pfaff [mailto:blp at ovn.org]
> > Sent: Friday, June 3, 2016 2:05 AM
> > To: Joe Stringer
> > Cc: Paul Boca; dev at openvswitch.org
> > Subject: Re: [ovs-dev] [PATCH V2 1/4] tests: Fixed access denied on ovs-
> > vswitchd.log
> > 
> > On Thu, Jun 02, 2016 at 03:55:41PM -0700, Joe Stringer wrote:
> > > On 1 June 2016 at 04:45, Paul Boca <pboca at cloudbasesolutions.com> wrote:
> > > > On Windows trying to overwrite the opened ovs-vswitchd.log
> > > > fails with access denied. Closing it before trying to overwrite it
> > > > solves the problem
> > > >
> > > > Signed-off-by: Paul-Daniel Boca <pboca at cloudbasesolutions.com>
> > >
> > > Ideally we don't introduce platform differences into the tests; the
> > > extra command should be available on both platforms, so you should be
> > > able to just add "ovs-appctl vlog/close" rather than introducing the
> > > if/else.
> > >
> > > If you don't have a linux environment to test, then you can push the
> > > patches to your github and get travis to try it for you.
> > 
> > Or for something as simple as this, just note in the change log that you
> > only tested on Windows, and then whoever reviews it should run the test
> > locally (I often do this in any case).



More information about the dev mailing list