[ovs-dev] [PATCH] datapath-windows: use ip proto for tunnel port lookup

[Nithin Raju]

Thanks for the review.

From: Yin Lin <yinlin10 at gmail.com<mailto:yinlin10 at gmail.com>>
Date: Thursday, June 2, 2016 at 3:00 PM
To: Nithin Raju <nithin at vmware.com<mailto:nithin at vmware.com>>
Cc: "dev at openvswitch.org<mailto:dev at openvswitch.org>" <dev at openvswitch.org<mailto:dev at openvswitch.org>>
Subject: Re: [ovs-dev] [PATCH] datapath-windows: use ip proto for tunnel port lookup

Thanks Nithin for working on this! The fix overall looks pretty good.

Can we get rid of OvsFindTunnelVportByPortType since it doesn't make much sense and is dangerous to call if user doesn't understand what it actually does?

Done in the v2.


Also, there is some misalignment in the following code. Did you use tab?

-            if (tunnelVport) {
+        tunnelVport =
+            OvsFindTunnelVportByDstPortAndNWProto(ovsFwdCtx->switchContext,
+                                                  dstPort,
+                                                  flowKey->ipKey.nwProto);
+        if (tunnelVport) {
+            switch(tunnelVport->ovsType) {
+            case OVS_VPORT_TYPE_STT:
                 ovsActionStats.rxStt++;
-            }

Alignment looks correct. I have checked it after applying the patch.

-- Nithin