[ovs-dev] [PATCH] tests: Skip vlog close and set if no python is installed

Ben Pfaff blp at ovn.org
Tue Jun 7 04:16:16 UTC 2016


On Fri, Jun 03, 2016 at 01:06:51PM +0000, Paul Boca wrote:
> AT_CAPTURE_FILE([log.old]) and AT_CAPTURE_FILE([log]) will fail in case no python
> is installed on the system
> 
> Signed-off-by: Paul-Daniel Boca <pboca at cloudbasesolutions.com>

I don't understand this.  AT_CAPTURE_FILE doesn't rely on Python.  Also,
AT_CAPTURE_FILE only has a visible effect when a test fails.

The documentation for AT_CAPTURE_FILE says:

 -- Macro: AT_CAPTURE_FILE (FILE)
     If the current test group fails, log the contents of FILE.  Several
     identical calls within one test group have no additional effect.

Maybe you see some other problem?

Thanks,

Ben.



More information about the dev mailing list