[ovs-dev] [PATCH] tests: Skip vlog close and set if no python is installed
Ben Pfaff
blp at ovn.org
Tue Jun 7 04:27:39 UTC 2016
On Mon, Jun 06, 2016 at 08:21:26PM +0000, Alin Serdean wrote:
> > -----Mesaj original-----
> > De la: dev [mailto:dev-bounces at openvswitch.org] În numele Paul Boca
> > Trimis: Friday, June 3, 2016 4:07 PM
> > Către: dev at openvswitch.org
> > Subiect: [ovs-dev] [PATCH] tests: Skip vlog close and set if no python is
> > installed
> >
> > AT_CAPTURE_FILE([log.old]) and AT_CAPTURE_FILE([log]) will fail in case no
> > python is installed on the system
> [Alin Gabriel Serdean: ] AT_CAPTURE_FILE will not fail if python is installed or not
Oh, you pointed out the same thing I did, silly me I should have read
your review first ;-)
> The python tests for vlog/close and vlog/set are disabled please see:
> https://github.com/openvswitch/ovs/blob/master/tests/vlog.at#L350-L351
> and
> https://github.com/openvswitch/ovs/blob/master/tests/vlog.at#L450-L451
>
> To skip the test please see:
> https://github.com/openvswitch/ovs/blob/master/tests/vlog.at#L115-L118
>
> Although we could make it work :).
>
> I tried to fix under windows and came up with the following it can be improved and also tested under linux :):
Does Lance Richardson's patch address this problem?
More information about the dev
mailing list