[ovs-dev] [PATCH] [PATCH v3 1/2] ovn-controller: Add 'na' action for ND

[Zong Kai LI]

On Wed, Jun 8, 2016 at 6:19 PM, Numan Siddique <nusiddiq at redhat.com> wrote:

>
>> --- a/ovn/ovn-sb.xml
>> +++ b/ovn/ovn-sb.xml
>> @@ -985,6 +985,55 @@
>>            <p><b>Prerequisite:</b> <code>ip4</code></p>
>>          </dd>
>>
>> +        <dt>
>> +          <code>na{<var>A</var>; <var>action</var>; </code>...<code>
>> };</code>
>> +        </dt>
>> +
>> +        <dd>
>> +          <p>
>> +            Temporarily replaces the IPv6 packet being processed by an NA
>> +            packet and executes each nested <var>action</var> on the NA
>> +            packet.  Actions following the <var>na</var> action, if any,
>> apply
>> +            to the original, unmodified packet.
>> +          </p>
>> +
>> +          <p>
>> +            The NA packet that this action operates on is initialized
>> based on
>> +            the IPv6 packet being processed(with userdata), as follows:
>> +          </p>
>> +
>> +          <ul>
>> +            <li><code>eth.dst</code> copied from eth.src</li>
>> +            <li><code>eth.src</code> copied from userdata</li>
>> +            <li><code>eth.type = 0x86dd</code></li>
>> +            <li><code>ip6.dst</code> copied from
>> <code>ip6.src</code></li>
>> +            <li><code>ip6.src</code> copied from
>> <code>nd.target</code></li>
>> +            <li><code>icmp6.type = 136</code> (Neighbor
>> Advertisement)</li>
>> +            <li><code>nd.target</code> unchanged</li>
>> +            <li><code>nd.sll = 00:00:00:00:00:00</code></li>
>> +            <li><code>nd.sll</code> copied from userdata</li>
>> +          </ul>
>> +
>> +          <p>
>> +            These are default values that the nested actions will
>> probably want
>> +            to change:
>> +          <p>
>> +
>> +          <ul>
>> +            <li><code>reg0 = 0x1</code>(Mark as replied by
>> ovn-controller)</li>
>> +            <li><code>outport</code> copied from inport</li>
>> +            <li><code>inport = ""</code></li>
>> +          </ul>
>> +
>> +            The ND packet has the same VLAN header, if any, as the IP
>> packet
>> +            it replaces.
>> +          </p>
>> +
>> +          <p>
>> +            <b>Prerequisite:</b> <code>nd&amp;&amp;icmp6.type ==
>> 135</code>
>> +          </p>
>> +        </dd>
>> +
>>
>>
> ​Hi Zong Kai LI,
> I am seeing compilation errors when I apply this patch. Probably some xml
> tag above has a mismatch.
>
> -----------
>   File "/usr/lib64/python2.7/xml/dom/expatbuilder.py", line 207, in
> parseFile
>     parser.Parse(buffer, 0)
> xml.parsers.expat.ExpatError: mismatched tag: line 1035, column 10
> Makefile:6208: recipe for target 'ovn/ovn-sb.5' failed
>
> ​------------​
>
>>
>> _______________________________________________
>> dev mailing list
>> dev at openvswitch.org
>> http://openvswitch.org/mailman/listinfo/dev
>>
>
>
Hi, Numan.
Sorry for that mistake, the correct things should be like:
diff --git a/ovn/ovn-sb.xml b/ovn/ovn-sb.xml
index 5189401..857105d 100644
--- a/ovn/ovn-sb.xml
+++ b/ovn/ovn-sb.xml
@@ -1017,7 +1017,7 @@
           <p>
             These are default values that the nested actions will probably
want
             to change:
-          <p>
+          </p>

           <ul>
             <li><code>reg0 = 0x1</code>(Mark as replied by
ovn-controller)</li>
@@ -1025,6 +1025,7 @@
             <li><code>inport = ""</code></li>
           </ul>

+          <p>
             The ND packet has the same VLAN header, if any, as the IP
packet
             it replaces.
           </p>

And I noticed you add a comment in the other patch: "This patch fails to
apply on the latest master.".
I'm not sure what does that mean? Once things get clear, I will try to
submit a new patch later.

Thanks for your time and have a nice day! :)

Best regards,
Zong Kai, LI