[ovs-dev] [PATCH] ofproto-dpif-upcall: prevent memory leak on log message

[Joe Stringer]

On 8 June 2016 at 09:04, Thadeu Lima de Souza Cascardo
<cascardo at redhat.com> wrote:
> When DPIF does not support UFID (like old kernels), it may print this message
> quite frequently, if using an OVS version that does not include the upstream fix
> af50de8 ("ofproto-dpif-upcall: Pass key to dpif_flow_get().").
>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo at redhat.com>
> Fixes: af50de8 ("ofproto-dpif-upcall: Pass key to dpif_flow_get().")

Thanks for the fix.

It seems to me that af50de8 ("ofproto-dpif-upcall: Pass key to
dpif_flow_get().") makes this problem less likely, while 64bb477f0568
("dpif: Minimize memory copy for revalidation.") is the commit which
actually introduced the bug. I updated the "Fixes:" tag and used this
commit to determine which branches the fix should apply to.

Applied to master, branch-2.5 and branch-2.4.