[ovs-dev] [PATCH 8/8] automake: Add ovs-bugtool.in to flake8-check.

[Russell Bryant]

On Thu, Jun 9, 2016 at 4:20 PM, Guru Shetty <guru at ovn.org> wrote:

> On 9 June 2016 at 13:14, Aaron Rosen <aaronorosen at gmail.com> wrote:
>
> > This patch seemed to break the build with some flake8 python3 errors for
> > me. I have a patch coming up to fix it.
> >
>
>
Sorry, I posted a patch before seeing this.

http://openvswitch.org/pipermail/dev/2016-June/072579.html


> Oink. Should I be doing more than a "pip install flake8" and make
> flake8-check to trigger these problems?


The issue is that you also need the "hacking" flake8 plugin.  "pip install
hacking" will do it.

We could detect if the hacking plugin is installed and force failure in
that case.  A better solution is to switch to a different method of running
flake8 that ensures everyone who runs it always runs it in a consistent
environment the same set of packages and versions.  I have a really old
patch that did that.  I think it's worth resurrecting it to avoid any more
of this problem.

-- 
Russell Bryant