[ovs-dev] [PATCH] Change vlog calls with ctl_fatal to make it consistent

nghosh at us.ibm.com nghosh at us.ibm.com
Thu Jun 9 19:57:25 UTC 2016


This change is just a minor cleanup to remove VLOG_WARN
from ovn-nbctl.c and use ctl_fatal. I believe, VLOG_WARN
is not supposed to be used here.

Signed-off-by: Nirapada Ghosh <nghosh at us.ibm.com>

---
 ovn/utilities/ovn-nbctl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c
index 321040e..8dc5fda 100644
--- a/ovn/utilities/ovn-nbctl.c
+++ b/ovn/utilities/ovn-nbctl.c
@@ -1523,11 +1523,11 @@ do_nbctl(const char *args, struct ctl_command *commands, size_t n_commands,
         }
         if (!symbol->strong_ref) {
             if (!symbol->weak_ref) {
-                VLOG_WARN("row id \"%s\" was created but no reference to it "
+                ctl_fatal("row id \"%s\" was created but no reference to it "
                           "was inserted, so it will not actually appear in "
                           "the database", node->name);
             } else {
-                VLOG_WARN("row id \"%s\" was created but only a weak "
+                ctl_fatal("row id \"%s\" was created but only a weak "
                           "reference to it was inserted, so it will not "
                           "actually appear in the database", node->name);
             }
-- 
2.7.4 (Apple Git-66)




More information about the dev mailing list