[ovs-dev] [PATCH] replace VLOG_WARN with ctl_fatal

Ben Pfaff blp at ovn.org
Fri Jun 10 03:20:42 UTC 2016


On Tue, May 24, 2016 at 04:29:02PM -0700, nghosh at us.ibm.com wrote:
> This change is just a minor cleanup to remove VLOG_WARN
> from ovn-nbctl.c and use ctl_fatal. I believe, VLOG_WARN
> is not supposed to be used here.
> 
> Signed-off-by: Nirapada Ghosh <nghosh at us.ibm.com>
> 
> ---
>  ovn/utilities/ovn-nbctl.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c
> index f9783da..a0ea5ac 100644
> --- a/ovn/utilities/ovn-nbctl.c
> +++ b/ovn/utilities/ovn-nbctl.c
> @@ -1476,11 +1476,11 @@ do_nbctl(const char *args, struct ctl_command *commands, size_t n_commands,
>          }
>          if (!symbol->strong_ref) {
>              if (!symbol->weak_ref) {
> -                VLOG_WARN("row id \"%s\" was created but no reference to it "
> +                ctl_fatal("row id \"%s\" was created but no reference to it "
>                            "was inserted, so it will not actually appear in "
>                            "the database", node->name);
>              } else {
> -                VLOG_WARN("row id \"%s\" was created but only a weak "
> +                ctl_fatal("row id \"%s\" was created but only a weak "
>                            "reference to it was inserted, so it will not "
>                            "actually appear in the database", node->name);
>              }

This is only supposed to be a warning because it's at least remotely
possible that it's not a mistake.



More information about the dev mailing list