[ovs-dev] [PATCH 8/8] ovn-nbctl: Update logical switch commands.

Justin Pettit jpettit at ovn.org
Sun Jun 12 00:39:08 UTC 2016


> On Jun 9, 2016, at 3:32 PM, Ben Pfaff <blp at ovn.org> wrote:
> 
> On Thu, Jun 09, 2016 at 12:12:42AM -0700, Justin Pettit wrote:
>>    A few minor changes related to logical switch commands:
>> 
>>        - Use "ls" instead of "lswitch" to be more consistent with other
>>          command changes.
>>        - Use commands where possible in ovn unit tests.
>>        - Update references from "lswitch" to "ls" (code) or "switch" (user).
>> 
>> Signed-off-by: Justin Pettit <jpettit at ovn.org>
> 
> The "ls-" prefix on command names makes it look like it should list
> something.  To resolve the possible confusion, I suggest that you submit
> a patch to the GNU coreutils maintainers to change the name of /bin/ls.

Good idea!  I'm also thinking about changing "ls-list" to "ls-ls".  However, for Russell, he should know that the first "ls" is for "list" and the second is for "logical switch".

(Just so people don't get scared, that was joke about renaming the command.)

> Acked-by: Ben Pfaff <blp at ovn.org>

Thanks for all the reviews, guys!  I've pushed the series.

--Justin





More information about the dev mailing list