[ovs-dev] [PATCH] VxLAN-gpe implementation
Yang, Yi
yi.y.yang at intel.com
Sun Jun 12 12:53:23 UTC 2016
On Mon, Jun 06, 2016 at 02:22:58PM -0700, Jesse Gross wrote:
> On Sat, Jun 4, 2016 at 6:39 AM, Yi Yang <yi.y.yang at intel.com> wrote:
> [...]
> > datapath/vport-netdev.c | 3 +-
> > datapath/vport-vxlan.c | 17 ++-
>
> These changes aren't upstream yet. Please do that before backporting them here.
>
> However, the changes to vport-vxlan.c are modifying compatibility code
> that shouldn't be extended further. Instead, just use the existing
> VXLAN netlink interfaces that have already been created to enable
> these features.
Jesse, sorry for late reply, I will submit a kernel patch for this.
>
> There is also a number of other patches to the OVS kernel module/VXLAN
> that have not been backported. Pravin started doing this work but it
> hasn't been applied yet. In general, I think it makes sense to
> backport patches in order so that the diffs of the patches match those
> of upstream.
Pravin, can you send your patch link to me? I will rebase my patch on
your patch, or you can include VxLAN-gpe part in your patch.
>
> Finally, I have a question about receive side offloading with
> VXLAN-gpe. This is primarily an upstream issue but is present in the
> code being backported here as well. The VXLAN code sets up receive
> offloads for all ports regardless of whether they are classic VXLAN or
> L2/L3 GPE and expects NICs to parse the packets. I don't think this is
> safe because there are a number of NICs out there that predate the
> existence of GPE and therefore won't do this parsing correctly. I
> think that it is necessary to disable receive offloading for
> non-Ethernet VXLAN-GPE unless the offloading interface is extended.
Ok, will do. Jesse, thank you so much for your great comments.
More information about the dev
mailing list