[ovs-dev] [PATCH 00/10] datapath: NAT backports

Jesse Gross jesse at kernel.org
Tue Jun 14 00:31:09 UTC 2016


On Thu, Jun 9, 2016 at 3:45 PM, Jarno Rajahalme <jarno at ovn.org> wrote:
> This series adds the conntrack NAT integration upstreamed in Linux 4.6
> to the OVS tree kernel module.  Main code is the same as upstream,
> backports are provided for Linux kernels 3.10 - 4.3.  Code compiles on
> the latest release of each Linux version on this range.  Linux 4.4 and
> 4.5 remain untested as OVS tree kernel module does not yet support
> them.

Can you check 4.4-4.6 to see if any additional backports are needed?
(There might not be any if it already works on older kernels.) It has
been reported that things seem to generally work up to 4.6 just by
removing the configure check so it shouldn't be hard to test. We're
trying to get support for 4.6 in so if we skip the backports for this
then it will just add more to the backlog of things that will need to
be immediately addressed.

> I have retained the original Acks for patches that are simple
> "cherry-picks" from upstream patches.  In some cases I have squashed
> in later bug fixes so that the end result is identical to the current
> net-next upstream.

Can you include the upstream git hash in the commit message of each
patch? This makes it significantly easier to review. Here's an example
of the format that we've generally used for backports:
http://openvswitch.org/pipermail/dev/2016-June/072572.html

The closer we can keep each patch to its upstream equivalent, the
easier it is to maintain things.



More information about the dev mailing list