[ovs-dev] [ovs-dev, PATCH 3/4] ovn-controller: Add 'put_dhcp_opts' action in ovn-controller

Ryan Moats rmoats at us.ibm.com
Tue Jun 14 14:47:30 UTC 2016


"dev" <dev-bounces at openvswitch.org> wrote on 06/09/2016 12:37:58 AM:

> From: Ben Pfaff <blp at ovn.org>
> To: dev at openvswitch.org
> Cc: Ben Pfaff <blp at ovn.org>
> Date: 06/09/2016 12:58 AM
> Subject: [ovs-dev, PATCH 3/4] ovn-controller: Add 'put_dhcp_opts' action
in ovn-controller
> Sent by: "dev" <dev-bounces at openvswitch.org>
>
> From: Numan Siddique <nusiddiq at redhat.com>
>
> This patch adds a new OVN action 'put_dhcp_opts' to support native
> DHCP in OVN.
>
> ovn-controller parses this action and adds a NXT_PACKET_IN2
> OF flow with 'pause' flag set and the DHCP options stored in
> 'userdata' field.
>
> When the valid DHCP packet is received by ovn-controller, it frames a
> new DHCP reply packet with the DHCP options present in the
> 'userdata' field and resumes the packet and stores 1 in the OVS
> register provded in the 'put_dhcp_opts' parameter. If the packet is
invalid,
> it resumes the packet without any modifying and stores 0 in the OVS
register.
>
> Eg. put_dhcp_opts(reg0, efferip = 10.0.0.4, router = 10.0.0.1,
>                   netmask = 255.255.255.0, lease_time = 3600,....)
>
> A new 'DHCP_Options' table is added in SB DB which stores
> the supported DHCP options with DHCP code and type. ovn-northd is
> expected to popule this table.
>
> The next patch will add logical flows with this action.
>
> Signed-off-by: Numan Siddique <nusiddiq at redhat.com>
> Co-authored-by: Ben Pfaff <blp at ovn.org>
> Signed-off-by: Ben Pfaff <blp at ovn.org>
> ---

As a counter example to the last email, this patch set has a goto which
I'm comfortable with (as the alternative hits my personal cyclomatic
complexity limit)

Acked-by: Ryan Moats <rmoats at us.ibm.com>



More information about the dev mailing list