[ovs-dev] [PATCH] [PATCH, v4, 1/2] ovn-controller: Add 'na' action for ND

[Ryan Moats]

"dev" <dev-bounces at openvswitch.org> wrote on 06/14/2016 10:09:37 PM:

> From: Zong Kai LI <zealokii at gmail.com>
> To: dev at openvswitch.org
> Cc: Zong Kai LI <zealokii at gmail.com>
> Date: 06/14/2016 10:11 PM
> Subject: [ovs-dev] [PATCH] [PATCH, v4, 1/2] ovn-controller: Add 'na'
> action for ND
> Sent by: "dev" <dev-bounces at openvswitch.org>
>
> This patch adds a new OVN action 'na' to support ND versus ARP.
>
> When ovn-controller received a ND packet, it frames a template
> NA packet for reply. The NA packet will be initialized based on
> ND packet, such as NA packet will use:
>  - ND packet eth.src as eth.dst,
>  - ND packet eth.dst as eth.src,
>  - ND packet ip6.src as ip6.dst,
>  - ND packet nd.target as ip6.src,
>  - ND packet eth.dst as nd.tll.
>
> Then nested actions in 'na' action will update necessary fileds
> for NA packet, such as:
>  - eth.src, nd.tll
>  - inport, outport
>
> Eg. na { eth.src = 12:34:56:78:9a:bc; nd.tll = 12:34:56:78:9a:bc;
>          outport = inport; inport = ""; /* Allow sending out inport. */
>          output; };
>
> Since patch port for IPv6 router interface is not ready yet, this
> patch will only try to deal with ND from VM. This patch will set
> RSO flags to 011 for NA packets.
>
> The next patch will do logical flows works for this action.
>
> Signed-off-by: Zong Kai LI <zealokii at gmail.com>
> ---

While the patch applies cleanly, the new ND test that has been
added to tests/ovn.at fails to pass - the output indicates
that the NA packet is not seen by VIF1:

hv1/vif1-tx.pcap
./ovn.at:3219: cat $i.packets
--- expout      2016-06-15 14:02:42.486004483 +0000
+++ /home/stack/git/ovs/tests/testsuite.dir/at-groups/2061/stdout
2016-06-15 14:02:42.486004483 +0000
@@ -1 +0,0 @@
-fa163e940598fa163ea1f9ae86dd6000000000203afffd81ce49a9480000f8163efffea1f9aefd81ce49a9480000f8163efffe9405988800e9ed60000000fd81ce49a9480000f8163efffea1f9ae0201fa163ea1f9ae

Because of this, I didn't review the second patch in the series...

Ryan Moats