[ovs-dev] [PATCH v6] datapath-windows: Add Geneve support

Nithin Raju nithin at vmware.com
Sat Jun 18 00:46:25 UTC 2016


From: Yin Lin <yinlin10 at gmail.com<mailto:yinlin10 at gmail.com>>
Date: Friday, June 17, 2016 at 5:10 PM
To: "aserdean at cloudbasesolutions.com<mailto:aserdean at cloudbasesolutions.com>" <aserdean at cloudbasesolutions.com<mailto:aserdean at cloudbasesolutions.com>>, Nithin Raju <nithin at vmware.com<mailto:nithin at vmware.com>>
Cc: Yin Lin <linyi at vmware.com<mailto:linyi at vmware.com>>, "dev at openvswitch.org<mailto:dev at openvswitch.org>" <dev at openvswitch.org<mailto:dev at openvswitch.org>>
Subject: Re: [ovs-dev] [PATCH v6] datapath-windows: Add Geneve support

Thanks Alin and Nithin for the review and Jesse for the clarification.

I've addressed all the comments except this one:

"One general comment is that we are validating the tunnel options in the
hot path - basically for each packet when we execute the actions for the
flow. Obvious solution for this is to validate the flow ONLY during flow
add. Can you add a flag to OvsTunnelAttrToGeneveOptions() that tells the
function to validate only during flow add?"

In order to address this we need to propagate the flag all the way down.
Besides, there are other callers to this function such as OvsExecuteSetAction.
We need to evaluate whether validation is required in such cases.
Can I address the optimization in a separate patch? It looks like we always
do the validation on Linux and didn't optimize either.

Thanks Yin. Like Jesse mentioned, we don't have a full fledged flow-validation logic on Hyper-V. It is a pending work item.

While we get to it, this is what I had in mind in the meantime:
MapTunAttrToFlowPut() -> OvsTunnelAttrToGeneveOptions(validate = TRUE)
OvsTunnelAttrToIPv4TunnelKey() -> OvsTunnelAttrToGeneveOptions(validate = FALSE)

Do you see issues with this?

Thanks,
-- Nithin



More information about the dev mailing list