[ovs-dev] tests: fix issue in use of OVS_APP_EXIT_AND_WAIT

[Lance Richardson]

----- Original Message -----
> From: "Paul Boca" <pboca at cloudbasesolutions.com>
> To: "Lance Richardson" <lrichard at redhat.com>, "Alin Serdean" <aserdean at cloudbasesolutions.com>
> Cc: dev at openvswitch.org
> Sent: Tuesday, June 21, 2016 5:37:59 AM
> Subject: RE: tests: fix issue in use of OVS_APP_EXIT_AND_WAIT
> 
> Hi Lance!
> 
> One small change that should be added to your patch.
> 
> diff --git a/tests/ovs-vsctl.at b/tests/ovs-vsctl.at
> index ac8749a..5171786 100644
> --- a/tests/ovs-vsctl.at
> +++ b/tests/ovs-vsctl.at
> @@ -9,7 +9,7 @@ m4_define([OVS_VSCTL_SETUP],
>  dnl OVS_VSCTL_CLEANUP
>  dnl
>  dnl Kills off the database server.
> -m4_define([OVS_VSCTL_CLEANUP], [OVS_APP_EXIT_AND_WAIT(["`pwd`"/unixctl])])
> +m4_define([OVS_VSCTL_CLEANUP],
> [OVS_APP_EXIT_AND_WAIT_BY_TARGET(["`pwd`"/unixctl], ["`pwd`"/pid])])
>  
>  dnl RUN_OVS_VSCTL(COMMAND, ...)
>  dnl
> 
> This only affects some Python tests.
> 
> Thanks,
> Paul

Hi Paul,

That issue, which was introduced after v1 had been posted, was addressed in v2.
v2 was posted to the ovs-dev list on June 10 (hmm, hopefully v2 isn't getting
too stale...):

   http://openvswitch.org/pipermail/dev/2016-June/072679.html

Any other issues?

Thanks,

   Lance