[ovs-dev] [RFC PATCH 07/14] Add APIs to set NSH keys for match fields

[Jesse Gross]

On Mon, Jun 20, 2016 at 9:02 PM, Li, Johnson <johnson.li at intel.com> wrote:
>   2) Add framework codes (or full implementation) for MD type 2 support of
>       the NSH header. According to the discussion at
>       http://comments.gmane.org/gmane.network.openvswitch.devel/53788
>       I will reuse the definitions for METADATA[0...63]. Since NSH is not one of
>       The tunneling encapsulation headers, renaming for the fields is required.
>       This might be a huge change for the current code base:

Please see this discussion with you coworker from 6 months ago:
http://openvswitch.org/pipermail/dev/2015-December/063306.html

You guys already renamed the fields once. At this point, you need to
live with what is there since we're not going to break compatibility
with previous releases.

>     3) Add "Ethernet + NSH" support for the OVS.  Following the discussion at
>          http://comments.gmane.org/gmane.network.openvswitch.devel/53788
>          we will introduce new match fields "encap_eth_dst/encap_eth_src" and
>          related openflow actions"push_encap_eth/pop_encap_eth".  Since we
>           treat outer Ethernet header as encapsulation header, so NO VLAN and
>          MPLS tags are supported for the outer header. That means packets with
>          Format "Ethernet + VLAN[|MPLS] + NSH + Ethernet + IPv4[|IPv6] + playload"
>          Will be dropped by the OVS when parsing the packets.
>          Examples for Ethernet NSH case:

Please make a generalized push/pop Ethernet header rather than a
specialized one for this case. There are other use cases that involve
this and they should be consistent (i.e. connecting an L3 tunnel to an
L2 interface, MAC-in-MAC encapsulation, etc.)