[ovs-dev] [PATCH] ovn: Allow IP packets destined to router ip for SNAT
Chandra S Vejendla
csvejend at us.ibm.com
Wed Jun 22 01:36:43 UTC 2016
By default all the ip traffic destined to router ip is dropped in
lr_in_ip_input stage. When the router ip is used as snat ip, allow
reverse snat traffic destined to the router ip.
Signed-off-by: Chandra Sekhar Vejendla <csvejend at us.ibm.com>
---
ovn/northd/ovn-northd.c | 33 ++++++++++++++++++++++++++++-----
1 file changed, 28 insertions(+), 5 deletions(-)
diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c
index 17713ec..6ff303e 100644
--- a/ovn/northd/ovn-northd.c
+++ b/ovn/northd/ovn-northd.c
@@ -2046,11 +2046,34 @@ build_lrouter_flows(struct hmap *datapaths, struct hmap *ports,
free(actions);
}
- /* Drop IP traffic to this router. */
- match = xasprintf("ip4.dst == "IP_FMT, IP_ARGS(op->ip));
- ovn_lflow_add(lflows, op->od, S_ROUTER_IN_IP_INPUT, 60,
- match, "drop;");
- free(match);
+ /* Drop IP traffic to this router, unless the router ip is used as
+ * snat ip. */
+ bool snat_ip_is_router_ip = false;
+ for (int i = 0; i < op->od->nbr->n_nat && !snat_ip_is_router_ip; i++) {
+ const struct nbrec_nat *nat;
+ ovs_be32 ip;
+
+ nat = op->od->nbr->nat[i];
+ if (strcmp(nat->type, "snat")) {
+ continue;
+ }
+ if (!ip_parse(nat->external_ip, &ip) || !ip) {
+ static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 1);
+ VLOG_WARN_RL(&rl, "bad ip address %s in snat configuration "
+ "for router %s", nat->external_ip, op->key);
+ continue;
+ }
+ if (ip == op->ip) {
+ snat_ip_is_router_ip = true;
+ }
+ }
+
+ if (!snat_ip_is_router_ip) {
+ match = xasprintf("ip4.dst == "IP_FMT, IP_ARGS(op->ip));
+ ovn_lflow_add(lflows, op->od, S_ROUTER_IN_IP_INPUT, 60, match,
+ "drop;");
+ free(match);
+ }
}
/* NAT in Gateway routers. */
--
2.6.1
More information about the dev
mailing list