[ovs-dev] [add ovsdb lock tests 2/3] ovsdb: Add ovsdb-client options for testing lock

Ben Pfaff blp at ovn.org
Thu Jun 23 19:23:15 UTC 2016


On Mon, Jun 06, 2016 at 01:51:15PM -0700, Andy Zhou wrote:
> RFC 7047 lock operation has been fully implemented in ovsdb-server
> for a while, but it is not well covered in unit testing. This
> patch adds options for the ovsdb-client tool to issue lock operations.
> The next patch will make use those options.
> 
> Please see ovsdb-client(1) changes for more details.
> 
> Signed-off-by: Andy Zhou <azhou at ovn.org>

Most ovsdb-client commands are useful to end users, but I think that
these commands are unlikely to be useful outside of testing.  That is
fine, but it might be worthwhile to mention that in the documentation.
For example, there could be a section header for "TESTING COMMANDS" and
a sentence that says that the following commands are mostly of interest
for testing the correctness of the OVSDB server.

There is a typo in the manpage, s/eixt/exit/.

The words in "quotes" in the manpage look to me like they would usually
be written in \fBbold\fR in the manpage style.

Acked-by: Ben Pfaff <blp at ovn.org>

Thanks,

Ben.



More information about the dev mailing list