[ovs-dev] [PATCH v5] JSON serialization via Python's json lib

Ben Pfaff blp at ovn.org
Thu Jun 23 23:15:34 UTC 2016


On Fri, Jun 10, 2016 at 01:54:42AM -0500, Terry Wilson wrote:
> There is no particularly good reason to use our own Python JSON
> serialization implementation when serialization can be done faster
> with Python's built-in JSON library.
> 
> A few tests were changed due to Python's default JSON library
> returning slightly more precise floating point numbers.
> 
> Signed-off-by: Terry Wilson <twilson at redhat.com>

I get a build failure when builddir != srcdir:

-*- mode: compilation; default-directory: "~/nicira/ovs/" -*-
Compilation started at Thu Jun 23 16:15:28

ovs-build-all _build
make  all-recursive
Making all in datapath
make[3]: 'distfiles' is up to date.
make[2]: Entering directory '/home/blp/nicira/ovs/_build'
cd ../python/ && /usr/bin/python3 setup.py build_ext --inplace
running build_ext
building 'ovs._json' extension
i586-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -I/usr/include/python3.5m -c ovs/_json.c -o build/temp.linux-x86_64-3.5/ovs/_json.o
ovs/_json.c:2:34: fatal error: openvswitch/lib/json.h: No such file or directory
 #include <openvswitch/lib/json.h>
                                  ^
compilation terminated.
***************************************************************************
WARNING: The C extension could not be compiled, speedups are not enabled.
Failure information, if any, is above.
Retrying the build without the C extension.
***************************************************************************
running build_ext
make[2]: Leaving directory '/home/blp/nicira/ovs/_build'

Compilation finished at Thu Jun 23 16:15:29



More information about the dev mailing list