[ovs-dev] [PATCH 1/1] rpm: Update rhel/automake.mk to build via mock

Flavio Leitner fbl at sysclose.org
Thu Jun 23 23:23:28 UTC 2016


On Tue, Jun 07, 2016 at 04:23:14PM -0400, Leif Madsen wrote:
> Provides changes to the automake.mk file in the rhel/ directory to utilize mock
> instead of rpmbuild for the rpm-fedora build target. The usage of mock provides
> an isolated environment for building packages, and makes things reproducible in
> various environment by relying on the spec file for a list of dependencies to
> install.
> 
> Documentation has been updated to reflect this change by noting that mock is a
> package dependency.
> 
> It has also been noted that the existing package list for buil dependencies
> remains unchanged for now, as the kmod packages are still utilizing rpmbuild. A
> submission in the future will update the rpm-fedora-kmod build target to work
> in a similar manner to what is being provided here.

Although the idea is nice, it doesn't seem like a good idea to force
everyone to install mock and download all dependencies when we can go
ahead and just build.

Perhaps it is possible to have a variable to select mock, e.g.:
make rpm-fedora MOCK_ROOT="epel-7-x86_64"
and that would use mock to build.

Or even a new target:
make rpm-mock-fedora MOCK_ROOT="epel-7-x86_64"

What do you think?

Thanks,
-- 
fbl




More information about the dev mailing list