[ovs-dev] [ovs-dev,v18,5/9] Refactor lflow.c

Ryan Moats rmoats at us.ibm.com
Fri Jun 24 00:55:54 UTC 2016


Ben Pfaff <blp at ovn.org> wrote on 06/23/2016 06:13:10 PM:

> From: Ben Pfaff <blp at ovn.org>
> To: Ryan Moats/Omaha/IBM at IBMUS
> Cc: dev at openvswitch.org
> Date: 06/23/2016 06:13 PM
> Subject: Re: [ovs-dev,v18,5/9] Refactor lflow.c
>
> On Thu, Jun 23, 2016 at 04:45:06PM -0500, Ryan Moats wrote:
> > Ben Pfaff <blp at ovn.org> wrote on 06/23/2016 04:40:01 PM:
> >
> > > From: Ben Pfaff <blp at ovn.org>
> > > To: Ryan Moats/Omaha/IBM at IBMUS
> > > Cc: dev at openvswitch.org
> > > Date: 06/23/2016 04:40 PM
> > > Subject: Re: [ovs-dev,v18,5/9] Refactor lflow.c
> > >
> > > On Wed, Jun 08, 2016 at 08:02:58PM -0500, Ryan Moats wrote:
> > > > From: "RYAN D. MOATS" <rmoats at us.ibm.com>
> > > >
> > > > Refactor code block inside of SBREC_LOGICAL_FLOW_FOR_EACH
> > > > loop in add_logical_flow so that this can be reused when
> > > > incremental processing is added.
> > > >
> > > > Signed-off-by: RYAN D. MOATS <rmoats at us.ibm.com>
> > >
> > > Patches 5-8 seem OK to me at first glance; they're mostly moving code
> > > around.
> > >
> > > I'll wait for a revision of patch 4 before looking at them in detail.
> >
> > That's up to you, they are pretty much independent of patch 4, but
> > I can re-roll them as well.
>
> I considered applying them independently but I got some rejects without
> applying patch 4, so there are at least trivial dependenices.
>

Yeah, I tried to reorder the patches this evening and hit the fact that the
rebase isn't clean.  C'est la vie.

Ryan



More information about the dev mailing list