[ovs-dev] [PATCH] ovn-controller: Use new ovsdb-idl helpers to make logic more readable.

Ben Pfaff blp at ovn.org
Fri Jun 24 03:58:03 UTC 2016


On Thu, Jun 23, 2016 at 10:48:31PM -0500, Ryan Moats wrote:
> Ben Pfaff <blp at ovn.org> wrote on 06/23/2016 10:33:53 PM:
> 
> > From: Ben Pfaff <blp at ovn.org>
> > To: Ryan Moats/Omaha/IBM at IBMUS
> > Cc: dev at openvswitch.org
> > Date: 06/23/2016 10:34 PM
> > Subject: Re: [ovs-dev] [PATCH] ovn-controller: Use new ovsdb-idl
> > helpers to make logic more readable.
> >
> > On Thu, Jun 23, 2016 at 08:01:52PM -0500, Ryan Moats wrote:
> > > "dev" <dev-bounces at openvswitch.org> wrote on 06/23/2016 07:00:51 PM:
> > >
> > > > From: Ben Pfaff <blp at ovn.org>
> > > > To: dev at openvswitch.org
> > > > Cc: Ben Pfaff <blp at ovn.org>
> > > > Date: 06/23/2016 07:01 PM
> > > > Subject: [ovs-dev] [PATCH] ovn-controller: Use new ovsdb-idl helpers
> > > > to make logic more readable.
> > > > Sent by: "dev" <dev-bounces at openvswitch.org>
> > > >
> > > > Also there were lots of 'continue's sprinkled around that didn't seem
> to
> > > > be needed given some simple code rearrangement.
> > > >
> > > > Signed-off-by: Ben Pfaff <blp at ovn.org>
> > >
> > > I'll not only ack this, I'll pull it in and base my residual
> incremental
> > > processing patches on it because it makes it *MUCH* cleaner:
> > >
> > > Acked-by: Ryan Moats <rmoats at us.ibm.com>
> > >
> > > In fact .... Happily-acked-by :)
> >
> > Such enthusiasm!  And speed!
> >
> > Thanks, I applied this to master.
> >
> 
> Are you kidding, I was thinking "man, I should have thought of that!!!"

I swear I suggested it once.  At this point I figured an example would
make it more obvious ;-)



More information about the dev mailing list