[ovs-dev] [PATCH 1/1] rpm: Update rhel/automake.mk to build via mock

[Russell Bryant]

Thanks for the patch!

I appreciate the attention to detail in your first patch to OVS: including
Signed-off-by, updating AUTHORS, and updating documentation for your
changes.  Thanks!

I have one minor nit that could be addressed while you're updating this to
account for Flavio's feedback.

On Tue, Jun 7, 2016 at 4:23 PM, Leif Madsen <lmadsen at redhat.com> wrote:

> Provides changes to the automake.mk file in the rhel/ directory to
> utilize mock
> instead of rpmbuild for the rpm-fedora build target. The usage of mock
> provides
> an isolated environment for building packages, and makes things
> reproducible in
> various environment by relying on the spec file for a list of dependencies
> to
> install.
>
> Documentation has been updated to reflect this change by noting that mock
> is a
> package dependency.
>
> It has also been noted that the existing package list for buil dependencies
> remains unchanged for now, as the kmod packages are still utilizing
> rpmbuild. A
> submission in the future will update the rpm-fedora-kmod build target to
> work
> in a similar manner to what is being provided here.
>
> Signed-off-by: Leif Madsen <lmadsen at redhat.com>
> ---
>  AUTHORS           |  1 +
>  INSTALL.Fedora.md | 19 ++++++++++++++++---
>  rhel/automake.mk  | 15 ++++++++++++---
>  3 files changed, 29 insertions(+), 6 deletions(-)
>
> diff --git a/AUTHORS b/AUTHORS
> index 9fda4c1..18c1d3a 100644
> --- a/AUTHORS
> +++ b/AUTHORS
> @@ -133,6 +133,7 @@ Kyle Upton              kupton at baymicrosystems.com
>  Lance Richardson        lrichard at redhat.com
>  Lars Kellogg-Stedman    lars at redhat.com
>  Lei Huang               huang.f.lei at gmail.com
> +Leif Madsen             lmadsen at redhat.com
>  Leo Alterman            lalterman at nicira.com
>  Lilijun                 jerry.lilijun at huawei.com
>  Linda Sun               lsun at vmware.com
> diff --git a/INSTALL.Fedora.md b/INSTALL.Fedora.md
> index 12d9a72..5fff636 100644
> --- a/INSTALL.Fedora.md
> +++ b/INSTALL.Fedora.md
> @@ -12,8 +12,13 @@ for RHEL 7.x and its derivatives, including CentOS 7.x
> and Scientific Linux
>
>  Build Requirements
>  ------------------
> -The tools and packages that are required for building Open vSwitch are
> -documented in [INSTALL.md]. Specific packages (by package name) include:
> +The only package required for building Open vSwitch is `mock` as all
> +dependencies will be automatically installed from the package list within
> the
> +RPM spec files. The tools and packages that are required for building
> Open vSwitch are
> +documented in [INSTALL.md].
> +
> +However, to build the kmod packages require the following specific
> packages
>

This sentence is a little awkward.  Changing "require" to "requires" may be
enough.  We could also make it "building the kmod packages requires ...".

Flavio's feedback to still retain the option to run rpmbuild directly via a
separate makefile target seems reasonable, as well.

-- 
Russell Bryant