[ovs-dev] FW: Subject: [ovsdb-idl 1/1] Fix issues detected in Partial Map Update feature

Ben Pfaff blp at ovn.org
Fri Jun 24 21:21:45 UTC 2016


On Mon, Jun 20, 2016 at 03:15:07PM +0000, Lutz, Arnoldo wrote:
> Please find below a patch fixing a memory leak detected in partial map update feature.
> It seems the original mail got lost and it hasn't been checked.

I applied this patch to master.

It had a cast that wasn't needed, so I removed it:

diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c
index 758f886..9b3e933 100644
--- a/lib/ovsdb-idl.c
+++ b/lib/ovsdb-idl.c
@@ -2233,8 +2233,7 @@ ovsdb_idl_txn_extract_mutations(struct ovsdb_idl_row *row,
         } else if (row->old != NULL) {
             old_datum = &row->old[idx];
         } else {
-            old_datum = CONST_CAST(struct ovsdb_datum*,
-                                ovsdb_datum_default(&column->type));
+            old_datum = ovsdb_datum_default(&column->type);
         }
 
         del_set = json_array_create_empty();




More information about the dev mailing list