[ovs-dev] [PATCH V4 19/20] tests: Skip vlog tests that try to move opened file

Paul Boca pboca at cloudbasesolutions.com
Sun Jun 26 12:12:30 UTC 2016


On Windows if a file is opened by an application for writing, we cannot move
it until all handles to that file are closed.

Signed-off-by: Paul-Daniel Boca <pboca at cloudbasesolutions.com>
---
V3: Initial commit
V4: No changes
---
 tests/vlog.at | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tests/vlog.at b/tests/vlog.at
index bf14290..78f10df 100644
--- a/tests/vlog.at
+++ b/tests/vlog.at
@@ -148,6 +148,9 @@ AT_CLEANUP
 
 m4_define([VLOG_REOPEN_PYN],
   [AT_SETUP([vlog - vlog/reopen - $1])
+   # This test won't work as-is on Windows because Windows doesn't allow
+   # files that are open to be renamed.
+   AT_SKIP_IF([test "$IS_WIN32" = "yes"])
    AT_SKIP_IF([test $2 = no])
    on_exit 'kill `cat test-unixctl.py.pid`'
 
@@ -314,6 +317,9 @@ AT_CLEANUP
 
 m4_define([VLOG_CLOSE_PYN],
   [AT_SETUP([vlog - vlog/close - $1])
+   # This test won't work as-is on Windows because Windows doesn't allow
+   # files that are open to be renamed.
+   AT_SKIP_IF([test "$IS_WIN32" = "yes"])
    AT_SKIP_IF([test $2 = no])
    on_exit 'kill `cat test-unixctl.py.pid`'
 
-- 
2.7.2.windows.1



More information about the dev mailing list