[ovs-dev] [PATCHv2] bridge: allow OVS to interact with controller through sockets outside run dir

[Ansis Atteka]

On 27 June 2016 at 11:37, Jesse Gross <jesse at kernel.org> wrote:

> On Sat, Jun 25, 2016 at 4:38 PM, Ansis Atteka <aatteka at ovn.org> wrote:
> > diff --git a/lib/daemon.h b/lib/daemon.h
> > index 4990415..742f382 100644
> > --- a/lib/daemon.h
> > +++ b/lib/daemon.h
> [...]
> > +extern bool self_confine;
>
> I don't really like that this is global to everything - it seems too
> easy to accidentally assign to or at the very least be non-obvious
> where it is coming from. Can you make it a function call and also
> prefix the name with daemon_?
>
> I think it would also be nice to just include description of the 3
> reasons why you might want to use this flag from the commit message in
> the daemon man page. That makes it very clear when you should use this
> (or not).
>

Thanks for review. How about this one -
https://patchwork.ozlabs.org/patch/641301/ ?


> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>