[ovs-dev] [PATCH v4 1/2] Add address set support.
Babu Shanmugam
bschanmu at redhat.com
Tue Jun 28 07:04:50 UTC 2016
Hi Zong Kai LI,
Thank you for pointing it out. I will take care of this in v5.
Babu
On Monday 27 June 2016 08:39 PM, Zong Kai LI wrote:
>
>
> static bool
> +parse_macros(struct expr_context *ctx, struct expr_constant_set *cs,
> + size_t *allocated_values)
> +{
> + if (!ctx->macros) {
> + expr_syntax_error(ctx, "No macros defined.");
> + return false;
> + }
> +
> + struct expr_constant_set *addr_set
> + = shash_find_data(ctx->macros, ctx->lexer->token.s);
> + if (!addr_set) {
> + expr_syntax_error(ctx, "Unknown macro: '%s'",
> ctx->lexer->token.s);
> + return false;
> + }
> +
> + cs->type = EXPR_C_INTEGER;
>
>
> Hi, Babu.
> It's odd you don't directly fix here with assign_constant_set_type,
> but in the following patch.
> Hope it doesn't matter to others.
>
> Thanks.
> Zong Kai, LI
More information about the dev
mailing list