[ovs-dev] [PATCH V4 17/20] ovs-ofctl.at: Prevent msys from getting confused with ipv6 address.

[Paul Boca]

Hi!

Thanks for the review!
Yes, the fullform of ::0/0 is 0:0:0:0:0:0:0:0/0, I think I copied the IP from your older patch.
The test didn’t fail even if I set the wrong fullform, because of the mask which is 0.

I will send another version as soon as more patches from this series are reviewed (to not spam the ML).

Thanks,
Paul

From: Guru Shetty [mailto:guru at ovn.org]
Sent: Tuesday, June 28, 2016 5:48 PM
To: Paul Boca
Cc: dev at openvswitch.org
Subject: Re: [ovs-dev] [PATCH V4 17/20] ovs-ofctl.at: Prevent msys from getting confused with ipv6 address.



On 26 June 2016 at 05:12, Paul Boca <pboca at cloudbasesolutions.com<mailto:pboca at cloudbasesolutions.com>> wrote:
msys converts ::0/0 into ;c:\MinGW\msys\1.0\1.

To prevent this, use fullform ipv6 address of the form 0:0:0:0:0:0:0:1 instead.

Isn't the fullform of ::0/0  0:0:0:0:0:0:0:0/0 and not 0:0:0:0:0:0:0:1/0 ?

Signed-off-by: Paul-Daniel Boca <pboca at cloudbasesolutions.com<mailto:pboca at cloudbasesolutions.com>>
---
V3: Initial commit
V4: No changes
---
 tests/ovn-nbctl.at<http://ovn-nbctl.at> | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/ovn-nbctl.at<http://ovn-nbctl.at> b/tests/ovn-nbctl.at<http://ovn-nbctl.at>
index 91d482b..fd67c6d 100644
--- a/tests/ovn-nbctl.at<http://ovn-nbctl.at>
+++ b/tests/ovn-nbctl.at<http://ovn-nbctl.at>
@@ -407,7 +407,7 @@ AT_CHECK([ovn-nbctl lr-route-list lr0], [0], [dnl
 ])

 dnl Check IPv6 routes
-AT_CHECK([ovn-nbctl lr-route-add lr0 ::/0 2001:0db8:0:f101::1])
+AT_CHECK([ovn-nbctl lr-route-add lr0 0:0:0:0:0:0:0:1/0 2001:0db8:0:f101::1])
 AT_CHECK([ovn-nbctl lr-route-add lr0 2001:0db8:0::/64 2001:0db8:0:f102::1 lp0])
 AT_CHECK([ovn-nbctl lr-route-add lr0 2001:0db8:1::/64 2001:0db8:0:f103::1])

@@ -434,7 +434,7 @@ dnl Check IPv4 and IPv6 routes
 AT_CHECK([ovn-nbctl lr-route-add lr0 0.0.0.0/0<http://0.0.0.0/0> 192.168.0.1])
 AT_CHECK([ovn-nbctl lr-route-add lr0 10.0.1.1/24<http://10.0.1.1/24> 11.0.1.1 lp0])
 AT_CHECK([ovn-nbctl lr-route-add lr0 10.0.0.1/24<http://10.0.0.1/24> 11.0.0.1])
-AT_CHECK([ovn-nbctl lr-route-add lr0 ::/0 2001:0db8:0:f101::1])
+AT_CHECK([ovn-nbctl lr-route-add lr0 0:0:0:0:0:0:0:1/0 2001:0db8:0:f101::1])
 AT_CHECK([ovn-nbctl lr-route-add lr0 2001:0db8:0::/64 2001:0db8:0:f102::1 lp0])
 AT_CHECK([ovn-nbctl lr-route-add lr0 2001:0db8:1::/64 2001:0db8:0:f103::1])

--
2.7.2.windows.1
_______________________________________________
dev mailing list
dev at openvswitch.org<mailto:dev at openvswitch.org>
http://openvswitch.org/mailman/listinfo/dev